Comments

• 

  about 7 years ago by npower | Reply

  Hackweek update

  python yast

  I had a couple of goals, I believe that I certainly achieved those :-)

  I ported all 235 ruby examples from here

  For quite a while I was porting manually, after spending some time learning what needed to be changed and beginning to understand things more and finally realising my progress was way way too slow I created a really crappy conversion script Note: I realise this is not the optimal way to do a conversion, perhaps another hackweek project would be to learn abit about yacc/bison and write a proper translator. This however suited my need to actually interact with the code to learn some stuff :)

  They are working in the majority of cases.

  I found a few issues with the current python bindings that we are working on.

  summary of the week

  Number of examples: 235

  Number of examples ported: 235

  Number not working: 15-20 approx. With the exception of 1 (SlideShowDemo2.py) all of these are non functional due to missing SCR, Directory and Pkg module/functions

  Issues:

  • missing Builtins functions, currently the builtins used in the examples are calling new python functions in a module called ycpbuiltins (because of a namespace clash with 'builtins') we could probably use a module name of 'Builtins' but afaik convention is for lowercase modules. Note: If the c++ equivelant functions are available then it might make sense to use these. However for some e.g. y2error, y2warning, y2milestone etc. we need to natively wrap these in order to capture the file and line number information from the stack frame to add to the debug message. Currently the python ycpbuiltin module just does that and writes just to stdout at the moment. These functions of course need to call the underlying ycp/c++ code to write to the log file (#TODO) other functions like some of the string and list helpers are probably easier done in native python code. some functions from ycp Builtins (like cryptbigcrypt should be call the appropriate ycp/C++ code)

  • we weren't handling complex Term expressions e.g.

    Term(sometext, somemoretext)

  or

  Term("ShowReleaseNotesButton", "&Release Notes", "release_notes")
  

  etc. The Python bindings are adjusted now to handle that

  • Numeric Id(). The new python bindings were by default just supporting an Id taking a single string param. However lots of the examples were taking int. Just replacing Id(1) with Id('1') worked for lots of the examples but closer to the completing the example conversions I came across some instances where this approach became a little awkward

    UI.ChangeWidget(Id(:table), Cell(@currentitemid, 1), @amount)

  Versus

  UI.ChangeWidget(Id("table"), Cell(Id(str(current_item_id)), 1), amount)
  

  The bindings now support numberic Id(s) like Id(1) etc. the examples ported are are currently coded like Id('1'). It would be good to review and rewrite again those ported examples again to work a little more like they were intended to work

  Note: not only can an int be passed to 'Id' it is also possible (and some of the examples do this) for other params like Term to be used for Id. e.g.

  RadioButton(Id(term(:unit, 0)), Opt(:notify)....)
  

  This is now converted like:

  RadioButton(Id(Term("unit", 0)), Opt("notify")..)

  • Some missing YCP functionality was identified that was preventing some examples from functioning

    • Missing SCR functions
    • Missing Pkg functions
    • Missing Directory functions

  • Handling of escaped string literals for utf-8 doesn't seem to work as expected, this is probably as a result of my poor python skills or something that needs specific handling in the bindings (see RichText1cs.py, SetLanguage.py Table1utf8.py (and others))

  • Use of the Wizard widget directly didn't work, attempting to add a Wizard Term to the existing set of Term functions failed due to namespace issues (with the Wizard module containing the Wizard functions like Wizard.CreateDialog() etc.) I am working around this by introducing YCPWizard in place of the Wizard UI term

  • There are times when ChangeWidget (probably other functions) doen't work as expected out of the box. This seems mainly due to the pattern of conversion we are using where

  in ruby a widget with and Item like

  Item( Id(:opt), "opt", false, ["kde", "netscape", "Office51"
  

  can be selected or changed to via

  UI.ChangeWidget(:dest_dir, :CurrentItem, :opt)
  

  but since we convert such an item as

  Item( Id("opt"), "opt", False, ["kde", "netscape", "Office51"]
  

  we sometimes need to do

   UI.ChangeWidget("dest_dir", "CurrentItem", Symbol("opt"))
  

  or

   UI.ChangeWidget("dest_dir", "CurrentItem", Id("opt"))
  

  similarly the Wizard Widget will not work with our standard conversion

  UI.OpenDialog( Opt(:defaultsize), Wizard( Opt(:stepsEnabled), :back, "&Back", :abort, "Ab&ort", :next, "&Next"))
  

  to

  UI.OpenDialog( Opt("defaultsize"), YCPWizard( Opt("stepsEnabled"), "back", "&Back", "abort", "Ab&ort", "next", "&Next"))
  

  will not work in this case it is necessary to do something like

  UI.OpenDialog(Opt("defaultsize"), YCPWizard( Opt("stepsEnabled"), Symbol("back"), "&Back", Symbol("abort"), "Ab&ort", Symbol("next"), "&Next"))
  

  The use of Id certainly linked with the use of Symbol, currently we automatically convert the string to a symbol if it is passed to Id. However we have seen that Id can take other types. It should be possible that someone may intentionally pass a string and expect it to be used with Id (without the autoconvert to symbol) However for brevity (and since the usecase where Id is a symbo l seems to be 99% of time) the Id function takes an optional param to override the autoconvertion of the string to symbol (see yast.py) * another issue is deep copy on swig objects doesn't work (need to investigate that to see what if anything can be done) * use of None should be converted to Void() causes some cores in places (nil in ruby works fine)

×
Edit Comment 3046
# A First Level Header
## A Second Level Header

Use one asterisk to *emphasize*

Use two asterisks for **strong emphasis**

- Use hyphens
- for unordereed
- lists

This is an [link to example.com](http://example.com/)

This is an image ![an openSUSE geeko icon](https://en.opensuse.org/images/d/d0/Icon-distribution.png)

This is a user link @hans

This is a project link hw#some-cool-title
More Complex Markdown Help
Formatting Help
• Edit
• Preview
# Hackweek update ## python yast I had a couple of goals, I believe that I certainly achieved those :-) I ported all 235 ruby examples from [here](https://github.com/yast/yast-ycp-ui-bindings/tree/master/examples) For quite a while I was porting manually, after spending some time learning what needed to be changed and beginning to understand things more and finally realising my progress was way way too slow I created a really crappy conversion [script](https://github.com/noelpower/yast-python-bindings/blob/hackweek-0x10/examples/ruby-convert-helper.py) Note: I realise this is not the optimal way to do a conversion, perhaps another hackweek project would be to learn abit about yacc/bison and write a proper translator. This however suited my need to actually interact with the code to learn some stuff :) They are working in the majority of cases. I found a few issues with the current python bindings that we are working on. ### summary of the week Number of examples: 235 Number of examples ported: 235 Number not working: 15-20 approx. With the exception of 1 (SlideShowDemo2.py) all of these are non functional due to missing SCR, Directory and Pkg module/functions #### Issues: * missing Builtins functions, currently the builtins used in the examples are calling new python functions in a module called ycpbuiltins (because of a namespace clash with 'builtins') we could probably use a module name of 'Builtins' but afaik convention is for lowercase modules. Note: If the c++ equivelant functions are available then it might make sense to use these. However for some e.g. y2error, y2warning, y2milestone etc. we need to natively wrap these in order to capture the file and line number information from the stack frame to add to the debug message. Currently the python ycpbuiltin module just does that and writes just to stdout at the moment. These functions of course need to call the underlying ycp/c++ code to write to the log file (#TODO) other functions like some of the string and list helpers are probably easier done in native python code. some functions from ycp Builtins (like cryptbigcrypt should be call the appropriate ycp/C++ code) * we weren't handling complex Term expressions e.g. Term(sometext, somemoretext) or Term("ShowReleaseNotesButton", "&Release Notes", "release_notes") etc. The Python bindings are adjusted now to handle that * Numeric Id(). The new python bindings were by default just supporting an Id taking a single string param. However lots of the examples were taking int. Just replacing Id(1) with Id('1') worked for lots of the examples but closer to the completing the example conversions I came across some instances where this approach became a little awkward UI.ChangeWidget(Id(:table), Cell([@current_item_id](/users/current_item_id), 1), [@amount](/users/amount)) Versus UI.ChangeWidget(Id("table"), Cell(Id(str(current_item_id)), 1), amount) The bindings now support numberic Id(s) like Id(1) etc. the examples ported are are currently coded like Id('1'). It would be good to review and rewrite again those ported examples again to work a little more like they were intended to work Note: not only can an int be passed to 'Id' it is also possible (and some of the examples do this) for other params like Term to be used for Id. e.g. RadioButton(Id(term(:unit, 0)), Opt(:notify)....) This is now converted like: RadioButton(Id(Term("unit", 0)), Opt("notify")..) * Some missing YCP functionality was identified that was preventing some examples from functioning * Missing SCR functions * Missing Pkg functions * Missing Directory functions * Handling of escaped string literals for utf-8 doesn't seem to work as expected, this is probably as a result of my poor python skills or something that needs specific handling in the bindings (see RichText1_cs.py, SetLanguage.py Table1_utf8.py (and others)) * Use of the Wizard widget directly didn't work, attempting to add a Wizard Term to the existing set of Term functions failed due to namespace issues (with the Wizard module containing the Wizard functions like Wizard.CreateDialog() etc.) I am working around this by introducing YCPWizard in place of the Wizard UI term * There are times when ChangeWidget (probably other functions) doen't work as expected out of the box. This seems mainly due to the pattern of conversion we are using where in ruby a widget with and Item like Item( Id(:opt), "opt", false, ["kde", "netscape", "Office51" can be selected or changed to via UI.ChangeWidget(:dest_dir, :CurrentItem, :opt) but since we convert such an item as Item( Id("opt"), "opt", False, ["kde", "netscape", "Office51"] we sometimes need to do UI.ChangeWidget("dest_dir", "CurrentItem", Symbol("opt")) or UI.ChangeWidget("dest_dir", "CurrentItem", Id("opt")) similarly the Wizard Widget will not work with our standard conversion UI.OpenDialog( Opt(:defaultsize), Wizard( Opt(:stepsEnabled), :back, "&Back", :abort, "Ab&ort", :next, "&Next")) to UI.OpenDialog( Opt("defaultsize"), YCPWizard( Opt("stepsEnabled"), "back", "&Back", "abort", "Ab&ort", "next", "&Next")) will not work in this case it is necessary to do something like UI.OpenDialog(Opt("defaultsize"), YCPWizard( Opt("stepsEnabled"), Symbol("back"), "&Back", Symbol("abort"), "Ab&ort", Symbol("next"), "&Next")) The use of Id certainly linked with the use of Symbol, currently we automatically convert the string to a symbol if it is passed to Id. However we have seen that Id can take other types. It should be possible that someone may intentionally pass a string and expect it to be used with Id (without the autoconvert to symbol) However for brevity (and since the usecase where Id is a symbo l seems to be 99% of time) the Id function takes an optional param to override the autoconvertion of the string to symbol (see yast.py) * another issue is deep copy on swig objects doesn't work (need to investigate that to see what if anything can be done) * use of None should be converted to Void() causes some cores in places (nil in ruby works fine)
 
×
Reply to npower
Hackweek update
python yast
I had a couple of goals, I believe that I certainly achieved those :-)
I ported all 235 ruby examples from here
For quite a while I was porting manually, after spending some time learning what needed to be changed and beginning to understand things more and finally realising my progress was way way too slow I created a really crappy conversion script Note: I realise this is not the optimal way to do a conversion, perhaps another hackweek project would be to learn abit about yacc/bison and write a proper translator. This however suited my need to actually interact with the code to learn some stuff :)
They are working in the majority of cases.
I found a few issues with the current python bindings that we are working on.
summary of the week
Number of examples: 235
Number of examples ported: 235
Number not working: 15-20 approx. With the exception of 1 (SlideShowDemo2.py) all of these are non functional due to missing SCR, Directory and Pkg module/functions
Issues:
• missing Builtins functions, currently the builtins used in the examples are calling new python functions in a module called ycpbuiltins (because of a namespace clash with 'builtins') we could probably use a module name of 'Builtins' but afaik convention is for lowercase modules. Note: If the c++ equivelant functions are available then it might make sense to use these. However for some e.g. y2error, y2warning, y2milestone etc. we need to natively wrap these in order to capture the file and line number information from the stack frame to add to the debug message. Currently the python ycpbuiltin module just does that and writes just to stdout at the moment. These functions of course need to call the underlying ycp/c++ code to write to the log file (#TODO) other functions like some of the string and list helpers are probably easier done in native python code. some functions from ycp Builtins (like cryptbigcrypt should be call the appropriate ycp/C++ code)

• we weren't handling complex Term expressions e.g.

  Term(sometext, somemoretext)
or
Term("ShowReleaseNotesButton", "&Release Notes", "release_notes")
etc. The Python bindings are adjusted now to handle that
• Numeric Id(). The new python bindings were by default just supporting an Id taking a single string param. However lots of the examples were taking int. Just replacing Id(1) with Id('1') worked for lots of the examples but closer to the completing the example conversions I came across some instances where this approach became a little awkward

  UI.ChangeWidget(Id(:table), Cell(@currentitemid, 1), @amount)
Versus
UI.ChangeWidget(Id("table"), Cell(Id(str(current_item_id)), 1), amount)
The bindings now support numberic Id(s) like Id(1) etc. the examples ported are are currently coded like Id('1'). It would be good to review and rewrite again those ported examples again to work a little more like they were intended to work
Note: not only can an int be passed to 'Id' it is also possible (and some of the examples do this) for other params like Term to be used for Id. e.g.
RadioButton(Id(term(:unit, 0)), Opt(:notify)....)
This is now converted like:
RadioButton(Id(Term("unit", 0)), Opt("notify")..)
• Some missing YCP functionality was identified that was preventing some examples from functioning

  • Missing SCR functions
  • Missing Pkg functions
  • Missing Directory functions

• Handling of escaped string literals for utf-8 doesn't seem to work as expected, this is probably as a result of my poor python skills or something that needs specific handling in the bindings (see RichText1cs.py, SetLanguage.py Table1utf8.py (and others))

• Use of the Wizard widget directly didn't work, attempting to add a Wizard Term to the existing set of Term functions failed due to namespace issues (with the Wizard module containing the Wizard functions like Wizard.CreateDialog() etc.) I am working around this by introducing YCPWizard in place of the Wizard UI term

• There are times when ChangeWidget (probably other functions) doen't work as expected out of the box. This seems mainly due to the pattern of conversion we are using where
in ruby a widget with and Item like
Item( Id(:opt), "opt", false, ["kde", "netscape", "Office51"
can be selected or changed to via
UI.ChangeWidget(:dest_dir, :CurrentItem, :opt)
but since we convert such an item as
Item( Id("opt"), "opt", False, ["kde", "netscape", "Office51"]
we sometimes need to do
 UI.ChangeWidget("dest_dir", "CurrentItem", Symbol("opt"))
or
 UI.ChangeWidget("dest_dir", "CurrentItem", Id("opt"))
similarly the Wizard Widget will not work with our standard conversion
UI.OpenDialog( Opt(:defaultsize), Wizard( Opt(:stepsEnabled), :back, "&Back", :abort, "Ab&ort", :next, "&Next"))
to
UI.OpenDialog( Opt("defaultsize"), YCPWizard( Opt("stepsEnabled"), "back", "&Back", "abort", "Ab&ort", "next", "&Next"))
will not work in this case it is necessary to do something like
UI.OpenDialog(Opt("defaultsize"), YCPWizard( Opt("stepsEnabled"), Symbol("back"), "&Back", Symbol("abort"), "Ab&ort", Symbol("next"), "&Next"))
The use of Id certainly linked with the use of Symbol, currently we automatically convert the string to a symbol if it is passed to Id. However we have seen that Id can take other types. It should be possible that someone may intentionally pass a string and expect it to be used with Id (without the autoconvert to symbol) However for brevity (and since the usecase where Id is a symbo l seems to be 99% of time) the Id function takes an optional param to override the autoconvertion of the string to symbol (see yast.py) * another issue is deep copy on swig objects doesn't work (need to investigate that to see what if anything can be done) * use of None should be converted to Void() causes some cores in places (nil in ruby works fine)
---
# A First Level Header
## A Second Level Header

Use one asterisk to *emphasize*

Use two asterisks for **strong emphasis**

- Use hyphens
- for unordereed
- lists

This is an [link to example.com](http://example.com/)

This is an image ![an openSUSE geeko icon](https://en.opensuse.org/images/d/d0/Icon-distribution.png)

This is a user link @hans

This is a project link hw#some-cool-title
More Complex Markdown Help
Formatting Help
• Edit
• Preview